-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rerouting
to AssignmentReasonRecorder
#19252
Open
joeauyeung
wants to merge
12
commits into
main
Choose a base branch
from
add-rerouted-assignment-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7660746
Add `rerouting` to `AssignmentReasonRecorder`
joeauyeung 293d379
Pass session email as `rescheduledBy`
joeauyeung ff2c83c
Write reassign reason
joeauyeung 9b76d15
Edit message
joeauyeung 362ec40
Use `routingFormRoute` when rerouting
joeauyeung 48198c3
Pass isRerouting & reroutedByEmail to `routingFormRoute` method
joeauyeung 63d507d
Type fix
joeauyeung 0e5a210
Fix test
joeauyeung abcaf74
Fix test
joeauyeung 276b7cd
Fix test
joeauyeung 66e07fe
Type fix
joeauyeung 82a16dc
Merge branch 'main' into add-rerouted-assignment-handler
joeauyeung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
import { act, fireEvent, render, screen } from "@testing-library/react"; | ||
import type { Session } from "next-auth"; | ||
import { SessionProvider } from "next-auth/react"; | ||
import { vi } from "vitest"; | ||
|
||
import { RouteActionType } from "@calcom/app-store/routing-forms/zod"; | ||
|
@@ -36,6 +38,15 @@ const mockOpen = vi.fn((_url: string) => { | |
|
||
vi.stubGlobal("open", mockOpen); | ||
|
||
const mockSession = { | ||
expires: new Date(Date.now() + 2 * 86400).toISOString(), | ||
user: { | ||
id: 1, | ||
name: "Test User", | ||
email: "[email protected]", | ||
}, | ||
} as Session; | ||
|
||
vi.mock("@calcom/app-store/routing-forms/components/FormInputFields", () => ({ | ||
default: vi.fn(({ response, form, setResponse, disabledFields }) => { | ||
return ( | ||
|
@@ -383,7 +394,9 @@ describe("RerouteDialog", () => { | |
describe("New Routing tests", () => { | ||
test("when verify_new_route is clicked, the form is submitted", async () => { | ||
render( | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
<SessionProvider session={mockSession}> | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
</SessionProvider> | ||
); | ||
fireEvent.click(screen.getByText("verify_new_route")); | ||
|
||
|
@@ -402,7 +415,9 @@ describe("RerouteDialog", () => { | |
describe("New tab rescheduling", () => { | ||
test("new tab is closed when new booking is rerouted", async () => { | ||
render( | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
<SessionProvider session={mockSession}> | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
</SessionProvider> | ||
); | ||
clickVerifyNewRouteButton(); | ||
clickRescheduleToTheNewEventWithDifferentTimeslotButton(); | ||
|
@@ -441,7 +456,9 @@ describe("RerouteDialog", () => { | |
|
||
test("Rescheduling with same timeslot works", async () => { | ||
render( | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
<SessionProvider session={mockSession}> | ||
<RerouteDialog isOpenDialog={true} setIsOpenDialog={mockSetIsOpenDialog} booking={mockBooking} /> | ||
</SessionProvider> | ||
); | ||
clickVerifyNewRouteButton(); | ||
clickRescheduleWithSameTimeslotOfChosenEventButton(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reuse the logic that we use when recording the initial routing. That way we can see what attributes changed.