Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancelledby to work on api v1 #19268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shpadoinkle
Copy link
Contributor

@Shpadoinkle Shpadoinkle commented Feb 12, 2025

What does this PR do?

assigns cancelledby to the body, so it can actually be read and used by the handler.

api v1 support was a requirement of the original feature request.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • passing in a cancelledBy value on the query param should no longer be ignored. and actually store the value to the databse.

@Shpadoinkle Shpadoinkle requested a review from a team as a code owner February 12, 2025 21:44
Copy link

vercel bot commented Feb 12, 2025

@Shpadoinkle is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 12, 2025
@graphite-app graphite-app bot requested a review from a team February 12, 2025 21:44
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Feb 12, 2025
Copy link

graphite-app bot commented Feb 12, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/12/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/12/25)

1 label was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working community Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant