Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved EventsLimit page for mobile viewports #19270

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: Improved EventsLimit page for mobile viewports #19270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3907a6
Fixed mobile responsiveness UI bugs
harshit078 Feb 12, 2025
61ee3eb
Merge branch 'main' into events-limits-fix
harshit078 Feb 12, 2025
57cfd4a
Minor fix
harshit078 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions packages/features/eventtypes/components/tabs/limits/EventLimitsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,22 +115,24 @@ function RangeLimitRadioItem({
return (
<div
className={classNames(
"text-default mb-2 flex flex-wrap items-center text-sm",
"text-default mb-2 flex flex-col items-start text-sm sm:flex-row sm:items-center",
customClassNames?.wrapper
)}>
{!isDisabled && (
<RadioGroup.Item
id={radioValue}
value={radioValue}
className="min-w-4 bg-default border-default flex h-4 w-4 cursor-pointer items-center rounded-full border focus:border-2 focus:outline-none ltr:mr-2 rtl:ml-2">
<RadioGroup.Indicator className="after:bg-inverted relative flex h-4 w-4 items-center justify-center after:block after:h-2 after:w-2 after:rounded-full" />
</RadioGroup.Item>
)}
<div className="flex w-full items-center sm:w-auto">
{!isDisabled && (
<RadioGroup.Item
id={radioValue}
value={radioValue}
className="min-w-4 bg-default border-default flex h-4 w-4 cursor-pointer items-center rounded-full border focus:border-2 focus:outline-none ltr:mr-2 rtl:ml-2">
<RadioGroup.Indicator className="after:bg-inverted relative flex h-4 w-4 items-center justify-center after:block after:h-2 after:w-2 after:rounded-full" />
</RadioGroup.Item>
)}
<span>{t("within_date_range")}</span>
</div>
<div>
<span>{t("within_date_range")}&nbsp;</span>
<div
className={classNames(
"me-2 ms-2 inline-flex space-x-2 rtl:space-x-reverse",
"me-2 ms-0 mt-2 w-full sm:ms-2 sm:mt-0 sm:w-auto",
customClassNames?.datePickerWraper
)}>
<Controller
Expand Down Expand Up @@ -210,7 +212,7 @@ function RollingLimitRadioItem({
labelSrOnly
type="number"
className={classNames(
"border-default my-0 block w-16 text-sm [appearance:textfield] ltr:mr-2 rtl:ml-2",
"border-default my-0 block w-16 text-sm [appearance:textfield]",
customClassNames?.textField
)}
placeholder="30"
Expand All @@ -227,12 +229,15 @@ function RollingLimitRadioItem({
name="periodCoundCalendarDays"
value={getSelectedOption()}
defaultValue={getSelectedOption()}
className={customClassNames?.periodTypeSelect?.select}
className={classNames(
"!mt-0 ml-2 w-28 shrink sm:w-36",
customClassNames?.periodTypeSelect?.select
)}
innerClassNames={customClassNames?.periodTypeSelect?.innerClassNames}
/>
<span className="me-2 ms-2">&nbsp;{t("into_the_future")}</span>
</div>
<div className="py-2">
<div className="-ml-6 flex flex-col py-2">
<CheckboxField
checked={!!rollingExcludeUnavailableDays}
disabled={isDisabled}
Expand Down Expand Up @@ -831,14 +836,14 @@ const IntervalLimitItem = ({
<div
data-testid="add-limit"
className={classNames(
"mb-4 flex max-h-9 items-center space-x-2 text-sm rtl:space-x-reverse",
"mb-4 flex w-full min-w-0 items-center gap-x-2 text-sm rtl:space-x-reverse",
customClassNames?.container
)}
key={limitKey}>
<TextField
required
type="number"
containerClassName={textFieldSuffix ? "w-44 -mb-1" : "w-16 mb-0"}
containerClassName={textFieldSuffix ? "w-32 sm:w-44 -mb-1 shrink" : "w-14 sm:w-16 mb-0 shrink"}
className={classNames("mb-0", customClassNames?.limitText)}
placeholder={`${value}`}
disabled={disabled}
Expand Down
Loading