Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get org bookings endpoint api-v2 #20462

Merged
merged 18 commits into from
Apr 3, 2025
Merged

feat: get org bookings endpoint api-v2 #20462

merged 18 commits into from
Apr 3, 2025
+2,557 −636

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Mar 31, 2025 •
edited
Loading

What does this PR do?

Add endpoint to get bookings of an organization as an ORG_OWNER or ORG_ADMIN.

it should return all the bookings where members of the org are either within the Hosts or within the Attendees

refactored getBookings to be more readable

also now we fetch bookings where members of your team/org are attendees if you are team/org owner/admin

we now throw error 403 when trying to filter by members that are not within your org/team and 400 when trying to filter by non existing event-types

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Sorry, something went wrong.

@ThyMinimalDev ThyMinimalDev requested review from a team as code owners March 31, 2025 14:13
@ThyMinimalDev ThyMinimalDev marked this pull request as draft March 31, 2025 14:13
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 31, 2025
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth bookings area: bookings, availability, timezones, double booking organizations area: organizations, orgs labels Mar 31, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 1:03pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 1:03pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

E2E results are ready!

@ThyMinimalDev ThyMinimalDev added the high-risk Requires approval by Foundation team label Apr 3, 2025
@ThyMinimalDev ThyMinimalDev marked this pull request as ready for review April 3, 2025 09:40
@dosubot dosubot bot added the ✨ feature New feature or request label Apr 3, 2025
@ThyMinimalDev ThyMinimalDev requested a review from eunjae-lee April 3, 2025 09:42
eunjae-lee
eunjae-lee previously approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the awesome work! I'm really happy how clear this looks compared to before.

@ThyMinimalDev ThyMinimalDev requested review from zomars and emrysal April 3, 2025 14:01
hbjORbj
hbjORbj approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 👍

@hbjORbj hbjORbj merged commit da85395 into main Apr 3, 2025
39 checks passed
@hbjORbj hbjORbj deleted the get-org-bookings-v2 branch April 3, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj

@eunjae-lee eunjae-lee

@zomars zomars

@emrysal emrysal

Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth bookings area: bookings, availability, timezones, double booking core area: core, team members only ✨ feature New feature or request high-risk Requires approval by Foundation team organizations area: organizations, orgs platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ThyMinimalDev @eunjae-lee @hbjORbj @keithwillcode