fix: improve text visibility on routing form cards (#26579)#28857
fix: improve text visibility on routing form cards (#26579)#28857ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Conversation
Replace JavaScript substring truncation with CSS line-clamp and remove aggressive truncate class from ListLinkItem link wrapper so text wraps properly on narrow viewports instead of being hidden. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughModified the 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Summary
The
ListLinkItemcomponent inpackages/ui/components/list/List.tsxwas hiding text on routing form cards at narrow viewports due to two issues:truncateclass on the Link wrapper forcedwhite-space: nowrap; overflow: hidden, preventing text from wrapping at allsubstring(0, 100)hard-truncated subheading text regardless of available spaceChanges:
truncatewithmin-w-0on the Link wrapper — allows flex child to shrink properly without forcing single-line textline-clamp-2— shows up to 2 lines with ellipsis, adapting to viewport widthleading-nonetoleading-normalon the subheading for proper multi-line spacingbreak-wordsto handle long unbroken stringsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Generated by Claude Code
Vibe coded by ousamabenyounes