fix: enable case-insensitive array comparison in jsonLogic operators#28862
Draft
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Draft
fix: enable case-insensitive array comparison in jsonLogic operators#28862ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Conversation
The ==, ===, !=, and !== operators compared arrays by reference (JS default), so two arrays with identical normalized values would always mismatch. Added an areEqual helper that compares normalized arrays element-by-element, and unskipped the previously-failing test. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
==,===,!=, and!==operators inpackages/lib/raqb/jsonLogic.tsto correctly compare arrays element-by-element instead of by JS reference equality.Problem
JavaScript's
==and===compare arrays by reference, so["hello", "world"] === ["hello", "world"]is alwaysfalse. This meant that multiselect "equals" comparisons in routing forms would never match, even when the selected values were identical.A skipped test (
should compare arrays case-insensitively) confirmed this bug.Fix
Added an
areEqualhelper that:Tests
it.skiptest for array comparison on=====,!==, and!=Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
All 23 tests should pass, including the previously-skipped array comparison test.
Checklist
Generated by Claude Code
Vibe coded by ousamabenyounes