Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates dependency versions across the monorepo: Next.js is bumped in several packages (multiple from 16.1.5 → 16.2.3; one example from 14.2.35 → 15.5.15). Vite is updated from 6.4.1 → 6.4.2 in several packages. DOMPurify, Kysely, and other package dependencies are version-bumped. The root package.json gains extensive Yarn resolution pins and updates to many transitive dependency versions (including rollup, serialize-javascript, node-forge, lodash, and others). No source exports or public API declarations were changed. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@example-apps/credential-sync/package.json`:
- Line 13: The page is using App Router hooks (useRouter, useSearchParams,
usePathname from next/navigation) inside a Pages Router component which can
yield null values; replace these with the Pages Router API from next/router,
read query params from router.query and guard your redirect logic with
router.isReady inside useEffect so you only compute and act on appSlug and
userId after the router is initialized; update any top-level reads of
searchParams?.get(...) to instead derive const { appSlug, userId } =
router.query (or parse them inside the isReady useEffect) and perform
push/replace redirects there.
In `@package.json`:
- Around line 162-168: The package.json root-level overrides for "svgo" and
"serialize-javascript" are unscoped and thus apply broadly; change them to
descriptor-scoped resolutions that match the exact yarn.lock descriptors (e.g.,
"svgo@<exact-version-or-descriptor>" and
"serialize-javascript@<exact-version-or-descriptor>") following the same scoping
pattern used for "picomatch", "minimatch", "yaml", and "ajv" in this block so
only the intended transitive packages are pinned and you preserve correct
dependency resolution/auditing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 252d5ac7-fb91-46fa-9e4f-ed48c74bcbc1
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (11)
apps/api/v1/package.jsonapps/web/package.jsonexample-apps/credential-sync/package.jsonpackage.jsonpackages/embeds/embed-core/package.jsonpackages/embeds/embed-react/package.jsonpackages/embeds/embed-snippet/package.jsonpackages/kysely/package.jsonpackages/platform/atoms/package.jsonpackages/platform/examples/base/package.jsonpackages/platform/libraries/package.json
# Conflicts: # yarn.lock
E2E results are ready! |
What does this PR do?
Refreshes yarn resolutions and direct dependency pins to keep the transitive dependency tree current. Updates existing resolutions to newer patch/minor versions and adds resolutions for packages that have drifted across multiple version ranges in the tree.
Changes
Direct dependency bumps:
apps/web/package.jsonnextapps/web/package.jsondompurifyapps/api/v1/package.jsonnextpackages/platform/examples/base/package.jsonnextexample-apps/credential-sync/package.jsonnextpackages/platform/atoms/package.jsondompurify/vitepackages/platform/libraries/package.jsonvitepackages/embeds/{embed-core,embed-react,embed-snippet}/package.jsonvitepackages/kysely/package.jsonkyselyRoot
package.jsonresolutions — updates to existing entries:rollup,qs,node-forge,serialize-javascript,tar,lodash,lodash-es,fast-xml-parser,@lingo.dev/_compiler/fast-xml-parser.Root
package.jsonresolutions — new entries:webpack,systeminformation,path-to-regexp(two ranges),picomatch(seven ranges),hono,express-rate-limit,svgo,bn.js,minimatch(range-specific entries for 3.x/5.x/8.x/9.x/10.x),multer,flatted,socket.io-parser,vite,defu,immutable,@hono/node-server,@xmldom/xmldom(split by 0.8.x and 0.9.x),yaml(multiple 2.x ranges),ajv(6.x and 8.x ranges),brace-expansion.Context
Yarn 4 resolutions match specific declared descriptors, so packages with the same major line pinned via different ranges (exact / tilde / caret) each need their own resolution entry. This is why
minimatch,yaml,ajv,picomatch, and@xmldom/xmldomappear multiple times — each entry covers a distinct descriptor actually declared in the tree.How should this be tested?
yarn installcompletes without errorsMandatory Tasks