fix: github comment edit #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tedspare any better ideas to get the comment Id ? |
tedspare
reviewed
Oct 16, 2023
tedspare
reviewed
Oct 16, 2023
tedspare
reviewed
Oct 16, 2023
tedspare
reviewed
Oct 16, 2023
tedspare
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Awesome work @Udit-takkar! 🙌 🚀
If it works, LGTM
As for storing the Linear comment ID in the footer of a comment, the only downside I see is the reference could be broken by a user manually removing the footer.
An alternative would be to map all Linear <> GitHub comment IDs in a new table. At our scale, there are 10k+ issues mapped, so there could be 100k+ comments.
Happy to merge this!
|
@tedspare okay 👌. Addressed all the comments.
Yes that's why I marked this PR as draft first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #17
What does this PR do?
If a comment is created using linear then if it is edited on github then the changes are also reflected on linear.
One way we can get the ID of comment to be updated on linear is to store it in github Footer comment when it is created on linear.
Test Plan
Screen.Recording.2023-10-12.at.2.10.05.AM.mov
Related Issues
#17
Which issue does this PR resolve?