Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/linear image expiry #163

Merged
merged 6 commits into from
May 9, 2024
Merged

Fix/linear image expiry #163

merged 6 commits into from
May 9, 2024

Conversation

rockingrohit9639
Copy link
Collaborator

Summary

What have you changed? Provide context for those unfamiliar with what you're working on!

Test Plan

How did you test your changes?

Related Issues

Which issue does this PR resolve?

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synclinear ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 6:06am

@tedspare
Copy link
Collaborator

tedspare commented May 3, 2024

Great work @rockingrohit9639!

Quick build error (run npm run build to repro):

image

SECONDS_IN_YEAR.toString() should do it!

@tedspare tedspare self-requested a review May 3, 2024 00:23
Copy link
Collaborator

@tedspare tedspare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedspare tedspare merged commit eecffee into main May 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants