Skip to content

Make Makefile Python targets use python3#139

Merged
calesthio merged 1 commit into
calesthio:mainfrom
CooperSheroy:catalina/makefile-python3-lint-20260623
Jun 23, 2026
Merged

Make Makefile Python targets use python3#139
calesthio merged 1 commit into
calesthio:mainfrom
CooperSheroy:catalina/makefile-python3-lint-20260623

Conversation

@CooperSheroy

@CooperSheroy CooperSheroy commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a configurable PYTHON variable that defaults to python3
  • run pip through $(PYTHON) -m pip for interpreter consistency
  • fix the lint target's composition validator path

Validation

  • make lint
  • git diff --check

@CooperSheroy CooperSheroy requested a review from calesthio as a code owner June 23, 2026 05:54

@rajpratham1 rajpratham1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid cross-platform improvement. Replacing hardcoded python commands with $(PYTHON) makes the Makefile more portable and respects the user's configured Python interpreter. Using python3 -m pip is also a recommended practice since it ensures packages are installed into the same interpreter that's executing the project. The small lint path correction (tools/composition_validator.py → tools/analysis/composition_validator.py) also appears consistent with the current project structure.

@calesthio calesthio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.. Solid PR

@calesthio calesthio merged commit 58578ce into calesthio:main Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants