fix(variation): track longest same-size shot run#290
Conversation
calesthio
left a comment
There was a problem hiding this comment.
Approved. I verified the reported variation-checker issue is real on main: separated same-size pairs are incorrectly accumulated into a "3 consecutive same-size shots" violation, while an actual run of three same-size shots is not flagged. On this PR, separated pairs no longer trigger the consecutive-shot violation, true runs of three are flagged, and an unspecified shot breaks the run as intended.
Reviewed per docs/PR_REVIEW_GUIDE.md. Local checks passed: tests/tools/test_variation_checker.py, tests/contracts/test_phase0_contracts.py, py_compile for the changed files, and git diff --check. python -m pytest tests/eval -q found no pytest-discoverable tests. GitHub's Validate Python check was still pending at review time.
|
Rebased on current |
680e4c1 to
d9962a6
Compare
d9962a6 to
466a51b
Compare
|
Rebased on latest |
Summary
unspecifiedgapsTesting
C:\Users\Jayesh\AppData\Local\Programs\Python\Python314\python.exe -m pytest tests/tools/test_variation_checker.pyCloses #268