Skip to content

fix(remotion): unblock local zero-key rendering#294

Open
ketpatil77 wants to merge 1 commit into
calesthio:mainfrom
ketpatil77:codex/openmontage-local-zero-key
Open

fix(remotion): unblock local zero-key rendering#294
ketpatil77 wants to merge 1 commit into
calesthio:mainfrom
ketpatil77:codex/openmontage-local-zero-key

Conversation

@ketpatil77

Copy link
Copy Markdown

Summary

  • fix Explainer local asset resolution so file:// and absolute Unix/Windows paths stay valid Remotion URIs
  • normalize local narration/music paths before writing Remotion props
  • mark Piper as DEGRADED when no voice model is installed and surface current piper.download_voices guidance

Testing

  • C:\Users\Jayesh\AppData\Local\Programs\Python\Python314\python.exe -m pytest tests\tools\test_remotion_local_asset_paths.py tests\tools\test_remotion_diagnostics.py tests\contracts\test_phase3_contracts.py -k "PiperTTS or remotion"

@ketpatil77 ketpatil77 requested a review from calesthio as a code owner July 4, 2026 14:23

@calesthio calesthio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the local zero-key rendering path. The Piper status direction is useful, but I’m requesting changes because the Remotion portion is an older partial approach that does not solve the render-time local asset failure described in the PR family.\n\nThe current diff normalizes local cuts and audio to ile:// URIs. However Remotion’s renderer rejects local ile:// resources and only reliably loads http(s) URLs or assets served from the composer public/ directory. That is why #238 moved to staging local assets into
emotion-composer/public/_om_assets and rewriting props to staticFile-relative paths. Keeping this PR as-is would still let local images/video/audio fail at render time despite the props looking normalized in the test.\n\nThere is also substantial overlap with #238, which already contains the broader staging work, stale-copy refresh, cinematic audio staging, and Piper voice resolution follow-ups. Please rebase this on the current rendering fix direction or close it in favor of #238 after its remaining Piper executable-status contract is fixed.\n\nI did not find a separate security issue here; this is a correctness/scope issue around the Remotion asset-loading contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants