Remove Unused Channel and Make Program more robust#13
Open
ziggie1984 wants to merge 1 commit intocallebtc:mainfrom
Open
Remove Unused Channel and Make Program more robust#13ziggie1984 wants to merge 1 commit intocallebtc:mainfrom
ziggie1984 wants to merge 1 commit intocallebtc:mainfrom
Conversation
Contributor
Author
|
Had this issue in my logs, somehow the program crashed because the javascript did not evaluate to a boolean, though it did all the time before, therefore adding a check. In doing so I removed the decision_chan because it was not used |
Contributor
Author
|
seems like javascript fvcks up if we use values of the 1ML interface which is just a dummy because it failed with an error as you see above This PR makes it more robust and checks for the boolean, if its not it will default to false |
e7a8788 to
797c458
Compare
Owner
|
I think it would've been better if we just used the decision chan instead of the return value, what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.