Repository navigation
perf(scroll-until): build the snapshot visibility index once per pass #2528
Description
Activity
Shipped in #2596. Two things the premise got wrong, worth recording before this closes:
scroll --untilresolves under thewaitrow, whose ambiguity isfirst-match. That row resolves throughlistSelectorChainMatches— existence-only, no visibility bookkeeping — so the index this issue pointed at ininternal/resolve.ts(analyzeSelectorMatches) is never built on this path. There was no pipeline index to thread. The remaining place two indexes meet is theispath, wherereadUniqueisfail-closedandselector-is.tsbuilds its own.- The per-candidate waste itself was real and is fixed:
evaluateIsPredicatetakes the capture'sSnapshotVisibilityinstead ofnodes, so a pass's candidates share one index.
Found next to the fix and deliberately left:
isSelectorVisible'sambiguousandoccludedarms are unreachable under thewaitrow (first-match,occlusion: 'ignore'). No--untiltest would notice either cell being flipped.iscomputesvisibleforeditable|selected|focusedpurely to fill the failuredetails, and computes a value nothing reads fortext. That, not the index, is the per-assertion cost left onis.isAssertionVisiblein@agent-device/selectorsandpackages/maestro/src/internal/snapshot-policy.tsare one rule twice. perf(scroll-until): answer every candidate from one visibility index #2596 removed the only difference between them (nodesvsvisibility), so one copy can go.--untilasks the candidates of the first alternative that matched, so--until A|Bcan keep scrolling past an on-screenB. The off-screen-twin trap, one level up.
Waste
src/daemon/scroll-until.ts:169evaluates.some((node) => evaluateIsPredicate(...))per pass;predicates.ts:77builds a freshcreateSnapshotVisibility(nodes)per candidate. The rule inpackages/contracts/src/snapshot-visibility.ts:135-141(#1970) says N candidates share one index.resolveSelectorPipeline, called just above, builds an equivalent index and discards it (resolve.ts:229). N is the matched selector set (1-5), so this is not a measurable wall-clock win; it is a correctness-of-shape fix. Added in #2436.Fix
Hoist the index out of the
.some()(one per pass). Thread the pipeline's index into the predicate if the seam is already there; otherwise leave that for the H2 capture-kit move. Three lines; no measurement gate, no perf claim.