Repository navigation
feat(browserstack): add --provider-appium-version to pin the hosted Appium server - #2609
Conversation
|
Reviewed at bb3daba. This looks clean: the flag is one new row in the BrowserStack device-feature table and goes through the existing plumbing to No CI checks have run on this head yet. |
thymikee
added
the
ready-for-human
|
Reviewed at bb3daba. No code findings: the flag is additive, follows the BrowserStack device-feature table, and its hunks do not overlap #2608. The live App Automate run in the description ran on the fork release v0.21.1-pelago.1. If you have a run on bb3daba, please link it. CI has not run yet on this fork PR, and there are no conflicts. |
|
No dedicated App Automate run on |
|
can you rebase to resolve conflicts please? |
…ppium server BrowserStack runs Appium 1.x for an App Automate session unless the request names a version in `bstack:options.appiumVersion`. The `mobile:` commands the WebDriver interactor issues (`deepLink`, `pressButton`, `activateApp`) need a 2.x or newer server, so a session left on the default fails those commands. `--provider-appium-version <version>` (alias `--appium-version`) joins the BrowserStack device-feature table beside `--provider-timezone` and friends, and threads through the same connection profile, lease scope, remote config and doctor surfaces. It is operator-only (`projectConfig: false`) and not recorded. Co-authored-by: Cursor <cursoragent@cursor.com>
bb3daba to
605274f
Compare
|
Rebased onto current |
|
released these two browserstack updates in 0.21.3 so you can test them live |
2 participants
Summary
BrowserStack runs Appium 1.x for an App Automate session unless the request names a version in
bstack:options.appiumVersion. Themobile:commands the WebDriver interactor issues (deepLink,pressButton,activateApp) need a 2.x or newer server, so a session left on the default fails those commands with no way to opt out from the CLI.--provider-appium-version <version>(alias--appium-version) joins the BrowserStack device-feature table beside--provider-timezoneand friends, followingdocs/agents/cli-flags.md: contracts (client-connection,lease-scope,remote-config-fields), connection flag definition + group, CLI client config, connection profile, remote config schema, doctor options,integration-progress-modelclassification, and the BrowserStack docs page. Operator-only (projectConfig: false), not recorded.18 files touched (+45 / −0). Independent of #2608; the two touch disjoint hunks of one shared integration test.
Validation
Tested commit: bb3daba
pnpm check:affected --base upstream/main --run— thescripts/change fails open to the full local set (59 checks). Every runnable gate passed exceptmutation-model, whose single failing assertion (scripts/mutation/ownership.test.ts—gestures.test.tsowningscroll-edge-state) fails identically on pristineupstream/mainad9b90614and is unrelated to this change.pnpm exec vitest run test/integration/provider-scenarios/cloud-webdriver-provider-adapters.test.ts packages/provider-webdriver/src/browserstack-device-features.test.ts src/cli/parser/__tests__/args-parse-session.test.ts— 60/60 passed.v0.21.1-pelago.1).