Repository navigation
Conversation
…mark Both harnesses answered a one-time question that has since shipped: the AX bridge viability decision (#2237) and the region-crop comparison (#2505). Nothing in src, packages, docs, CI, or the gate catalog references them, and their raw evidence stays on the evidence tags. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
This PR looks good at e057b79. It only deletes the iOS AX bridge spike and the PNG crop benchmark, and it touches no product route. CI is green and there are no conflicts. Nothing else needs to happen before merge. I did not run the build, fallow, or the test suite locally. I did not check the path-keyed fallow baseline entries, but a grep for the deleted names found none in tracked JSON, YAML, MD or TS files. The png-crop subpath export in packages/capture-kit is a separate library module, not the deleted benchmark. I did not check whether anything imported the benchmark's helpers from it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes two concluded evidence harnesses under
scripts/and theirpackage.jsonscripts and vitest includes:scripts/ios-ax-bridge-spike/(perf(ios): decide Simulator AX bridge viability (GO, Node-direct guest reader) #2237): the Simulator AX bridge viability decision was consumed; no production counterpart references it.scripts/png-crop-benchmark/(perf(scripts): add a device-free PNG crop benchmark #2505): it compared the retired whole-image crop against the shipped region crop, which no longer has a whole-image path to compare.Nothing in
src,packages,docs, workflows, or the gate catalog references either directory. Raw evidence stays on the evidence tags named in their READMEs. 37 files, pure deletion (4,099 lines); the gross-diff budget is exceeded only because whole directories go away.Validation
Tested at e057b79:
pnpm check:affected --runpassed (format, lint, typecheck, gate manifest, mutation model, check-affected tests). No runtime behavior changes, so no device run applies.🤖 Generated with Claude Code