Repository navigation
docs(interaction): state that click and press report dispatch, not landing - #3355
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
This PR is ready at 4539b1d. The change is small and the code looks right. Not blocking: the new paragraph in website/docs/docs/commands.md (https://github.com/callstack/agent-device/blob/4539b1d/website/docs/docs/commands.md#L467) names --verify and --settle but not the per-command flag names on press, and it sits among the fill/type notes rather than next to the click/press examples, so you can move it or leave it. The iOS smoke job failed with daemon_startup_failed after a 15s startup timeout. This diff only changes a tracking-issue URL constant, two help strings and one docs paragraph, so it does not touch daemon startup, and the failure looks unrelated. I judged that from the diff and the log excerpt and did not rerun the job. I also did not check that the macOS native backend acts through accessibility actions, or whether any test or snapshot pins the click/press description strings. There are no conflicts. Please rerun the Smoke Tests job before merge. |
…nding (#3335) Click and press help and the commands guide now say success means the tap was dispatched, and name --verify, --settle, and wait as the ways to confirm it landed. Both tap-outcome waivers in the guarantee matrix track #3335 instead of the closed #1081 umbrella. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a tap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4539b1d to
a315300
Compare
Summary
States the click/press success contract: success means the tap was dispatched, not that it landed on the element.
help click,help press, and the commands guide now say this and name--verify(changedFromBefore),--settle, andwait <selector>as the ways to confirm it landed. No runtime behavior changes.Both tap-outcome waivers in
interaction-guarantees.ts(TAP_OUTCOME_NOT_OBSERVED_GAP,DIRECT_IOS_OUTCOME_NOT_OBSERVED_GAP) now point theirtrackingIssueat #3335 instead of the closed #1081 umbrella.I put the help text in the click/press descriptions rather than the
workflowcard, because that card is already at its 9,100-byte budget.Refs #3335. That issue stays open to track the waived
outcomeObservationcell. The stale tap point found in the same evidence is #3354.3 files touched.
Validation
pnpm check:affected --runpassed on90d8fb035(2298 tests, plus command-doc coverage) and again on4539b1d48after review fixes to the wording.🤖 Generated with Claude Code