Skip to content

docs(interaction): state that click and press report dispatch, not landing - #3355

Merged
thymikee merged 2 commits into
mainfrom
docs/click-dispatch-contract-3335
Oct 10, 2026
Merged

thymikee merged 2 commits into
mainfrom
docs/click-dispatch-contract-3335

Conversation

@thymikee

@thymikee thymikee commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

States the click/press success contract: success means the tap was dispatched, not that it landed on the element. help click, help press, and the commands guide now say this and name --verify (changedFromBefore), --settle, and wait <selector> as the ways to confirm it landed. No runtime behavior changes.

Both tap-outcome waivers in interaction-guarantees.ts (TAP_OUTCOME_NOT_OBSERVED_GAP, DIRECT_IOS_OUTCOME_NOT_OBSERVED_GAP) now point their trackingIssue at #3335 instead of the closed #1081 umbrella.

I put the help text in the click/press descriptions rather than the workflow card, because that card is already at its 9,100-byte budget.

Refs #3335. That issue stays open to track the waived outcomeObservation cell. The stale tap point found in the same evidence is #3354.

3 files touched.

Validation

  • pnpm check:affected --run passed on 90d8fb035 (2298 tests, plus command-doc coverage) and again on 4539b1d48 after review fixes to the wording.
  • No device run, because nothing changed at runtime: the diff is help text, docs, and a tracking-issue URL.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-10 06:01 UTC

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.15 MB 5.15 MB +230 B
Package (unpacked) 5.15 MB 5.15 MB +230 B
Package (download) 1.55 MB 1.55 MB +40 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 20.9 ms 18.9 ms -2.0 ms
CLI --help 58.5 ms 53.7 ms -4.8 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread src/commands/interaction/metadata.ts Outdated
Comment thread website/docs/docs/commands.md Outdated
@thymikee

thymikee commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

This PR is ready at 4539b1d. The change is small and the code looks right.

Not blocking: the new paragraph in website/docs/docs/commands.md (https://github.com/callstack/agent-device/blob/4539b1d/website/docs/docs/commands.md#L467) names --verify and --settle but not the per-command flag names on press, and it sits among the fill/type notes rather than next to the click/press examples, so you can move it or leave it.

The iOS smoke job failed with daemon_startup_failed after a 15s startup timeout. This diff only changes a tracking-issue URL constant, two help strings and one docs paragraph, so it does not touch daemon startup, and the failure looks unrelated. I judged that from the diff and the log excerpt and did not rerun the job. I also did not check that the macOS native backend acts through accessibility actions, or whether any test or snapshot pins the click/press description strings. There are no conflicts. Please rerun the Smoke Tests job before merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 9, 2026
thymikee and others added 2 commits October 10, 2026 07:58
…nding (#3335)

Click and press help and the commands guide now say success means the tap
was dispatched, and name --verify, --settle, and wait as the ways to confirm
it landed. Both tap-outcome waivers in the guarantee matrix track #3335
instead of the closed #1081 umbrella.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a tap

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thymikee
thymikee force-pushed the docs/click-dispatch-contract-3335 branch from 4539b1d to a315300 Compare October 10, 2026 05:59
@thymikee
thymikee merged commit 87dbd70 into main Oct 10, 2026
19 checks passed
@thymikee
thymikee deleted the docs/click-dispatch-contract-3335 branch October 10, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interaction guarantee gaps (ADR 0011 umbrella)

1 participant