Repository navigation
refactor(apple): simplify warm runner ownership #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
be787ae
fix(ios): stop a warm runner from silently rebooting a shut-down simu…
thymikee 4315ff9
test(ios): cover the warm-runner destination watch (#3321)
thymikee 9f58f7f
chore(gates): classify the warm-runner notice module and edge (#3321)
thymikee bc01130
fix(ios): classify destination loss by device state and kill the reta…
thymikee 68b92ee
refactor(ios): split destination-loss classification into a boot read…
thymikee 5eb630b
fix(ios): own warm-runner retention in one place and classify replace…
thymikee 97360e1
test(ios): pin that a destination lost during retention stops the run…
thymikee b439430
fix(ios): restore a released retention window only while no one has t…
thymikee fbbf157
test(ios): assert the typed ownership reason and the reused session s…
thymikee dd52602
refactor(ios): one Simulator state probe, one env reader, and a watch…
thymikee 97f47a2
docs(ios): say what the state probe throws, what the env overrides ac…
thymikee e2fb955
fix(ios): a state probe that times out stops the runner as runner_unr…
thymikee 791bdd6
docs(ios): drop a stray bullet marker in the watch comment (#3321)
thymikee 9c71e66
fix(ios): give an unverifiable simulator state its own typed reason a…
thymikee dd9c0ae
docs(ios): wrap the watch and probe comments to the 100-column width …
thymikee fe6a625
refactor(ios): stop a retained runner on any lost listener instead of…
thymikee c1d59f1
refactor(apple): give retained runners one lifecycle owner
thymikee f234d54
chore(gates): remove retired warm-loss notice ownership
thymikee 06362ca
fix(apple): address retained runner review findings
thymikee 8afe959
docs(apple): wrap retained runner lifecycle explanation
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.