Skip to content

chore(deps): upgrade fallow to 3.32 - #3370

Merged
thymikee merged 2 commits into
chore/production-unused-exportsfrom
chore/fallow-3
Oct 10, 2026
Merged

thymikee merged 2 commits into
chore/production-unused-exportsfrom
chore/fallow-3

Conversation

@thymikee

@thymikee thymikee commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Upgrades fallow 2.104 → 3.32. 3.33.x is skipped because it is younger than pnpm's 24h minimum release age.

  • fallow 3 rejects the "comment" field, so the 80 .fallowrc.json notes become JSONC comments with the same text.
  • 3.32 makes --fail-on-issues fail on warn findings, which turns check:production-exports back into an enforcing gate (chore: baseline-free production-exports cleanup (#1276) #1282). The previous PR clears its findings.
  • scripts/** never ships, so ignoreFindings scopes that gate to shipped code. It stays in the module graph; a child ignorePatterns would replace the base config's array.

Health findings are unchanged (90 on both versions). 3.x also reports that 57 of the 145 entries in fallow-baselines/health.json are stale. They already were, 2.104 did not report it, and pruning them is left out of scope. It also newly reports 6 root devDependencies as unused. These are inherited, so they don't affect the audit gate.

4 files, +132/−119.

Validation

Tested c985ff34d (rebased on main 19203c620): pnpm check:affected --run passed (all runnable checks). check:fallow and check:production-exports pass on fallow 3.32.0.

🤖 Generated with Claude Code

@thymikee
thymikee added this pull request to stack #3371 October 10, 2026 14:10
@thymikee thymikee changed the title chore/fallow 3 chore(deps): upgrade fallow to 3.32 Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstack.github.io/agent-device/pr-preview/pr-3370/

Built to branch gh-pages at 2026-10-10 16:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.16 MB 5.16 MB -1 B
Package (unpacked) 5.16 MB 5.16 MB -1 B
Package (download) 1.55 MB 1.55 MB -7 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.8 ms 26.6 ms -0.2 ms
CLI --help 81.9 ms 83.3 ms +1.4 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@thymikee

Copy link
Copy Markdown
Member Author

The PR is ready at 5d190bd; I found no problems in the code.

Not blocking: the new ignoreFindings: ["scripts/**"] in fallow-production-exports.json now hides every scripts/ finding in the --production gate, so the per-symbol scripts/ ignoreExports entries in the base config look redundant (their comments say they exist only for that analysis: resolveVitestMaxWorkers, readTestScope, ownedTestFiles, and the scripts/ half of the help-conformance glob). You could drop them and rerun check:fallow and check:production-exports on 3.32, keeping any that check:fallow still needs outside --production with a reworded comment. You can take or leave this.

I did not run fallow 3.32 locally, so I have not verified that the checks pass or the 90 health findings. I also did not diff the lockfile for transitive bumps beyond fallow, and I did not verify the stale baseline count (57 of 145) or the 6 newly reported unused devDependencies that the PR body marks as out of scope.

CI is unclear: every job that is not green is cancelled or queued, and none has failure logs. The cancellations look like superseded runs on the stack. The jobs that run fallow (Lint & Format, Repo Guards, Typecheck & Package) overlap this diff, so please rerun them and get them green. The branch is stacked on #3369, so it also waits for that to merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 10, 2026
thymikee and others added 2 commits October 10, 2026 18:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts to shipped code

fallow 3 rejects the "comment" annotation field, so the 80 entry notes become
JSONC comments with the same text. fallow 3.32 also makes --fail-on-issues fail
on warn findings, which turns check:production-exports back into the gate #1282
intended. scripts/ never ships, so ignoreFindings scopes that gate to shipped
code without dropping scripts from the module graph (an inherited array such
as ignorePatterns would replace the base config's list).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thymikee
thymikee merged commit 117de1f into main Oct 10, 2026
27 of 38 checks passed
@thymikee
thymikee deleted the chore/fallow-3 branch October 10, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant