feat: option to add nitro views #805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Juozas-Petkelis , remember to add the template to the CI matrix |
satya164
force-pushed
the
main
branch
6 times, most recently
from
0b45375 to
7799977
Compare
|
Super nice! |
satya164
requested changes
Jun 21, 2025
There was a problem hiding this comment.
Hey @Juozas-Petkelis
Sorry for the delay in the review. Would you be able to fix the conflicts with main?
Comment on lines
+302
to
+370
| // nitro modules on xcode 16.2 requires ios 16 version because of the bug https://github.com/swiftlang/swift/issues/77909 | ||
| // full thread in https://github.com/mrousavy/nitro/issues/422 | ||
| if ( | ||
| config.project.viewConfig === 'nitro-view' || | ||
| config.project.moduleConfig === 'nitro-modules' | ||
| ) { | ||
| const newTargetVersion = 16.0; | ||
|
|
||
| const podfile = await fs.readFile( | ||
| path.join(directory, 'ios', 'Podfile'), | ||
| 'utf8' | ||
| ); | ||
|
|
||
| const postInstallLine = 'post_install do |installer|'; | ||
| // set pods deployement min version | ||
| const podVersionOverride = ` | ||
| installer.pods_project.targets.each do |target| | ||
| target.build_configurations.each do |config| | ||
| config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '${newTargetVersion}' | ||
| end | ||
| end | ||
| `; | ||
|
|
||
| const insertionIndex = podfile.indexOf(postInstallLine); | ||
|
|
||
| if (insertionIndex !== -1) { | ||
| const endOfMarkerLineIndex = podfile.indexOf('\n', insertionIndex); | ||
|
|
||
| if (endOfMarkerLineIndex !== -1) { | ||
| const updatedPodfileContent = | ||
| podfile.slice(0, endOfMarkerLineIndex) + | ||
| podVersionOverride + | ||
| podfile.slice(endOfMarkerLineIndex); | ||
|
|
||
| await fs.writeFile( | ||
| path.join(directory, 'ios', 'Podfile'), | ||
| updatedPodfileContent | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // set project deployement min version | ||
| const project = await fs.readFile( | ||
| path.join( | ||
| directory, | ||
| `ios/${config.project.name}Example.xcodeproj`, | ||
| 'project.pbxproj' | ||
| ), | ||
| 'utf8' | ||
| ); | ||
|
|
||
| // match whole IPHONEOS_DEPLOYMENT_TARGET line | ||
| const deployementLineRegex = | ||
| /^(\s*)IPHONEOS_DEPLOYMENT_TARGET\s*=\s*[^;]+;$/gm; | ||
| const replacementPattern = `$1IPHONEOS_DEPLOYMENT_TARGET = ${newTargetVersion};`; | ||
| const updatedContent = project.replace( | ||
| deployementLineRegex, | ||
| replacementPattern | ||
| ); | ||
|
|
||
| await fs.writeFile( | ||
| path.join( | ||
| directory, | ||
| `ios/${config.project.name}Example.xcodeproj`, | ||
| 'project.pbxproj' | ||
| ), | ||
| updatedContent | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'd rather not have a workaround for old code. we're testing on newer xcode version so this won't be tested properly. Lets remove this.
| @@ -18,13 +18,14 @@ yarn | |||
| ``` | |||
|
|
|||
| > Since the project relies on Yarn workspaces, you cannot use [`npm`](https://github.com/npm/cli) for development. | |||
| <% if (project.moduleConfig === 'nitro-modules') { -%> | |||
| > <% if (project.moduleConfig === 'nitro-modules' || project.viewConfig === 'nitro-view') { -%> | |||
Comment on lines
+37
to
39
|
|
||
| <% } -%> | ||
|
|
There was a problem hiding this comment.
I think this will add 2 new lines after processing so we should remove this new line - or add a new line above this block and remove the one after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the option to add a Nitro View Component when scaffolding a new library with
create-react-native-library.Nitro View selection during setup
Updates the example app generation for nitro modules to set the minimum iOS deployment target to 16.0 for both the project and its native dependencies. This change addresses an Xcode 12.2 compatibility issue where Nitro modules failed to build with the previous default target of iOS 15.1.
Updated the fallback Nitro Modules version to
0.25.2Test plan
bin/create-react-native-libraryyarn nitro-codegenand build example app for both platformsExample App