fix: always use udid from matched device #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
szymonrybczak
changed the title
satya164
reviewed
Apr 24, 2025
| @@ -91,6 +91,7 @@ export const createRun = async ( | |||
| } | |||
| loader.stop('Found available devices and simulators.'); | |||
| const device = await selectDevice(devices, args); | |||
| args.device = device?.udid | |||
There was a problem hiding this comment.
would be good to add a comment explaining why this is done
thymikee
approved these changes
Apr 25, 2025
thymikee
added a commit
that referenced
this pull request
Apr 28, 2025
* origin/main: feat: refactor and expose remote cache provider (#260) fix: move start from @react-native/community-cli-plugin (#288) fix: update gradle-wrapper (#287) fix: always use udid from matched device (#281) chore: v0.7.2 (#279) docs: Update migrating-from-community-cli.mdx (#284) docs: attribute @expo/fingerprint (#285) fix: support plugin in create-app chore: v0.7.1 (#278) fix: autolinking config missing project (#277) fix: bump template to v0.7.0 chore: cleanup ios brownfield android mention chore: v0.7.0 (#274) feat: upgrade templates to 0.79 (#275) fix: incorrectly resolving root (#276) chore: simplify welcome message and improve prompts (#273) docs: add logo (#272) chore: v0.6.2 (#268) fix: resolve project root to absolute path (#269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some reason using UDID works in some cases when using sim name with () doesn't work always, so let's use the matched device also use UDID.
Test plan
rnef run:ios --device "iPhone 16 Pro Max (iOS 18.4)"should use UDID as a param in thexcodebuildcommand.