Skip to content

Conversation

kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Oct 21, 2025

This implements option 1 of #262 by copying the Xcframeworks as-is and updating them in place when renaming, instead of recreating them from library files using xcodebuild -create-xcframework.

This implements support for both versioned as well as flat framework bundles.

@kraenhansen kraenhansen self-assigned this Oct 21, 2025
@kraenhansen kraenhansen added enhancement New feature or request Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) labels Oct 21, 2025
@kraenhansen kraenhansen requested a review from Copilot October 22, 2025 05:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes how Apple frameworks are linked by copying and modifying existing XCFrameworks in-place instead of recreating them with xcodebuild -create-xcframework. This implementation supports both flat (iOS/tvOS) and versioned (macOS) framework bundle structures.

Key changes:

  • Replaces XCFramework recreation with in-place modification via plist updates and file renaming
  • Adds Zod schemas to validate and parse framework/XCFramework Info.plist files
  • Implements separate logic paths for flat vs versioned framework bundles

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/host/src/node/cli/apple.ts Core refactoring: replaces xcodebuild recreation with direct plist manipulation and file operations; adds linkFramework, linkFlatFramework, and linkVersionedFramework functions
packages/host/src/node/cli/apple.test.ts Updates tests to cover new linking functions, adds binary creation with clang, verifies install names with otool
packages/host/package.json Moves zod from devDependencies to dependencies and updates to v4.1.11
.changeset/blue-parts-cheer.md Documents the change in linking approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant