Merged
Conversation
…m or full; ios.defaultMode sets the default A lease request carries an optional mode (slim or full) on every surface, replacing full and --full. ios.defaultMode replaces ios.slim.enabled and sets what a request with no mode gets; the acquisition coordinator is the one place that default is applied. Every worker honours both modes: the iOS driver returns a slim spec only for a slim request on 18.5 or newer, the core refuses a slim spec for any other request, and the spec's mode keeps slim and full devices in separate pools. Protocol raised to 8. Closes #178
…over the warm re-boot mode and retired-key stripping
…o response shows a spec's planned mode; the fake reports full on recovery
# Conflicts: # docs/CLI.md
# Conflicts: # src/contract/protocol.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178
A lease request can now choose its device mode.
mode(slimorfull) replacesfull/--fullon the CLI, MCP, HTTP, and the client.ios.defaultMode(defaultfull) replacesios.slim.enabledand sets what a request with no mode gets.LeaseAcquisitionCoordinatoris the one place a missing mode gets that default, and it accepts a slim spec only for a slim request.resolveSpecreturns a slim spec only for a slim request on 18.5 or newer.makeReadyreads the spec's mode from its options, and the driver no longer stampsfullinto its data.DeviceSpec.modekeeps slim and full devices in separate pools. The registry drops a storedfullon load.docs/andKNOWN-PITFALLS.mdare updated, including the upgrade step and the Capacity counts slim and full devices separately #174 budget pitfall.Done when (#178)
pnpm checkis green. Its steps were run one by one, because the local pnpm is too old to read the workspace file. Unit: 2168 passed. Fast e2e: 78 passed.src/cli/index.test.ts,src/core/config.test.ts). Docs and code are clean.e2e/slow-ios-slim.test.tsis rewritten for--modeandios.defaultMode.Completion conditions (#172)
--mode slimon a default-full worker is slim, and--mode fullon a default-slim worker skips idle slim devices. Covered only by the slow lane, which has not run. The fake-driver form is covered bylease-acquisition-coordinator.test.ts"device mode".full, and so is slim on Android. Covered by the iOSresolveSpectests and by the coordinator test for a driver that knows nothing of modes.mode, and their leases report it. Covered by contract, MCP, and HTTP tests (the leases'modecomes from Leases and device lists report the device mode #177).featureProfileand no HTTPslim; status and list showmode. Delivered by Leases and device lists report the device mode #177.full, a bad mode, and--fullare rejected. Covered by contract, server, MCP, HTTP, and CLI tests.ios.slim.enabledgets the unknown-key warning and defaultfull. Covered byconfig.test.ts.e2e/gateway-fleet.test.ts.advisories()tests anddeviceModeWiring.simlock configrendersios.defaultMode. Covered bye2e/daemon-lifecycle.test.ts. The four docs are updated.Review
Spec review: 11 findings, 5 fixed. Code review: 10 findings, 9 fixed.
Rejected:
--fullandios.slim.enabled. The spec requires tests that name them in order to prove they are gone. Spec needs: exclude test files from that grep.modeand amodeequal to the worker's default are different requests under one idempotency key. The default can differ per worker, so they do not mean the same thing.pnpm check, the slow lane, and the PR walk, and no diff can show those. They are reported in this body instead.resolveSpecreturns a full spec when no slim options are configured. A driver that cannot slim gives a full spec (ADR 0007 §4), and the daemon always passes those options.startDaemonhandsslimByDefaultto the iOS driver. That is a one-line pass-through, the mapping itself is tested indeviceModeWiring, and no fast-lane test runs a real iOS driver.Written by an agent.