Repository navigation
Conversation
Contributor
Author
Review ledger{"findings": []}Written by an agent. |
V3RON
marked this pull request as ready for review
October 20, 2026 16:37
V3RON
added this pull request to stack #782
October 20, 2026 16:37
3 tasks done
7 tasks done
This was referenced Oct 20, 2026
V3RON
added a commit
that referenced
this pull request
Oct 20, 2026
Closes #758 ### Status Implement: done (5/5, audit probed 22/22) Review: round 2 passed Hardware: n/a Gate: waiting for the stack Next: stack sync onto #783 once #775's CI fix lands ## Done when - [x] `pnpm test:changed` passes. - [x] `pnpm test:e2e e2e/token-route.test.ts e2e/http-api.test.ts` passes. - [x] `rg -n "tokens\.json" src docs --glob '!docs/internal/adr/**'` finds only the old-file lists, their tests and the `docs/CLI.md` upgrade section. ## Assumptions - Assumption: the transaction helper F13 names was not in `src/ports/sqlite.ts` — I moved `inTransaction` there from `src/state/open.ts` (state imports it back), the smallest way for `src/auth` to use it without importing state. - Assumption: a worker with only a `tokens.json` gets the worker's existing upgrade step word for word, as the spec says — I added no token-specific step to it. ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes. Rounds: 2. Tokens: 17.5M. Runs: 9. Cost USD: 3.8042. Agent seconds: 2546. Assessment: complete *Written by an agent.*
V3RON
added a commit
that referenced
this pull request
Oct 20, 2026
Closes #759 ### Status Implement: done (4/4, audit probed 4/4) Review: round 1 + fix-check passed Hardware: n/a Gate: waiting for the stack Next: gate the stack (#755 → #775 → #783 → #784 → #785 → #786) ## Done when - [x] `pnpm test:changed` passes. - [x] `rg -n "workers\.json" src docs --glob '!docs/internal/adr/**'` finds only the gateway's old-file list, its test and the `docs/CLI.md` upgrade section. ## Feature completion (#754) - [x] A worker restarted with fake drivers keeps devices, leases, requests, components and tokens: restart tests in #775 (`src/daemon/main.test.ts`), real tables in #783, tokens in #784. - [x] A gateway restarted keeps tokens and drains: #784 (join token across restart) and the e2e restart test here. - [x] A renew changes one row with 1,000 requests stored: test in #775. - [x] Refusals for each old file, a damaged or newer `state.db`, printed by `simlock status` at once with exit 1: #775, #784, this PR, and #785's e2e (`e2e/start-refusal.test.ts`). - [x] `docs/CLI.md` upgrade and downgrade steps, no live JSON file named: #775's section plus each PR's `rg` Done when line. ## Assumptions none ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 20.4M. Runs: 9. Cost USD: 2.3576. Agent seconds: 1557. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #757
Status
Implement: done (6/6, audit probed 6/6) Review: round 1 passed, 0 findings Hardware: n/a Gate: waiting for the stack
Next: stack on #775
Done when
pnpm test:changedpasses.rg -n "productionDeviceDataTables" src/daemon/main.tsshows it passed where task 1 passed the empty map.Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 15.6M.
Runs: 7. Cost USD: 2.0671. Agent seconds: 1666.
Assessment: complete
Written by an agent.