Prueba Tecnica Sergio #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calujord
reviewed
Mar 6, 2024
| private readonly ILogger<FeesController> _logger; | ||
|
|
||
|
|
||
| public FeesController(FeeService feeService, ILogger<FeesController> logger) |
There was a problem hiding this comment.
Se valor los comentario en la definición de cada método, función o clase
calujord
reviewed
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementación de Servicio de Fees con Repository Patterns y Dependency Injection
-- TODO: Añadir conexion a base de datos. Creada con code first.
-- En el Swagger, se han agregado tres solicitudes: una solicitud GET para obtener únicamente los datos externos del Web API, otra solicitud POST que recupera y almacena en la base de datos los datos obtenidos (consumo de API), y un método en el controlador de Fees que filtra por clave primaria.
Los requisitos del Readme especifican que debería ser un controlador independiente, pero con esta arquitectura orientada más hacia un servicio, he propuesto que sea un método dentro del controlador.