Allow using optional kwargs as part of the key.#128
Open
schinckel wants to merge 1 commit intocameronmaske:masterfrom
Open
Allow using optional kwargs as part of the key.#128schinckel wants to merge 1 commit intocameronmaske:masterfrom
schinckel wants to merge 1 commit intocameronmaske:masterfrom
Conversation
This could possibly be improved by ensuring we use the default value of the optional kwargs as part of the lock key, but I'm not sure how to get that.
Author
|
I'm not even sure it is possible to get the default kwargs - we'd need to introspect the task definition I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could possibly be improved by ensuring we use the default value of the optional kwargs as part of the lock key, but I'm not sure how to get that.