Skip to content

Add a new function that allows to create noupdate records - #50

Open
mmequignon wants to merge 2 commits into
camptocamp:masterfrom
mmequignon:add_create_function
Open

Add a new function that allows to create noupdate records#50
mmequignon wants to merge 2 commits into
camptocamp:masterfrom
mmequignon:add_create_function

Conversation

@mmequignon

Copy link
Copy Markdown
Member

No description provided.

Comment thread anthem/lyrics/records.py Outdated
if not record:
record = model.create(values)
add_xmlid(ctx, record, xmlid, noupdate)
return record

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we want the songs to be idempotent, so create is not a good player in this regard. Why not extending create_or_update with a noupdate argument?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because a noupdate record shouldn't be updated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, idempotence is guaranteed by the if not record condition.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with @guewen You can extending create_or_update function.
noupdateflag don't indicate that we never want to update a record.
It indicates we don't want update the record automatically with a module update.
Here, you call "manually" the create_or_update function, so if you don't want to update an existing record, just don't call the create_or_update function if record already exists.

Also, I would like to understand why you need this feature here.

  • If you need a "module" record with noupdate, you create it directly in your module with noupdate.
  • If you need an external record like __setup__.***, you just need to check in your script if the record exists before create it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me that a noupdate field can't be updated, I created a dedicated function for that reason. But that's not a big deal, I'll do whatever you want me to do.

Comment thread anthem/lyrics/records.py Outdated
if not record:
record = model.create(values)
add_xmlid(ctx, record, xmlid, noupdate)
return record

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with @guewen You can extending create_or_update function.
noupdateflag don't indicate that we never want to update a record.
It indicates we don't want update the record automatically with a module update.
Here, you call "manually" the create_or_update function, so if you don't want to update an existing record, just don't call the create_or_update function if record already exists.

Also, I would like to understand why you need this feature here.

  • If you need a "module" record with noupdate, you create it directly in your module with noupdate.
  • If you need an external record like __setup__.***, you just need to check in your script if the record exists before create it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants