-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(web-modeler): clarify Web Modeler public API OIDC setup #5325
Conversation
2f61242
to
ee9adba
Compare
93b6faf
to
716d9a1
Compare
@ingorichtsmeier Small ping to have a look at this @jfriedenstab feel free to hand over to another WMC engineer in case you don't have the capacity to review. |
Hi @wollefitz, I would recommend changing the names of the APIs to distinguish them clearly. I thought a while about them, and for our users, it is easier to name them the Web Modeler API (to support the Web Modeler User interface) and Web Modeler REST API (for public access). The client ID needs a clarification, too. Which one is really required and is used in the code? The ID of the confidential client or the ID of the public client? All values are created in step 3. (For the GENERIC configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review!
89279fe
to
a3d3bdb
Compare
a3d3bdb
to
a740a1d
Compare
@ingorichtsmeier @jfriedenstab Thanks for the thorough review - I made the suggested adjustments. Could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better than before.
@camunda/tech-writers I'll go ahead and merge this as this is mainly a technical change. If you identify something that has to be changed retroactively I'm happy to adjust! |
🧹 Preview environment for this PR has been torn down. |
Description
Closes https://github.com/camunda/web-modeler/issues/13603
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.