-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console Manage connectors #5363
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@johnBgood Here is a first draft for you - please add any further technical details you think might be needed, and also let me know whether this needs to be backported - currently I've added it for 8.7 & 8.8 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few miscellaneous comments. Nice, clean writing!
Thanks for the review @christinaausley - incorporated all your comments! 🚀 |
@johnBgood This PR is probably ready for your approval - you can view it at https://preview.docs.camunda.cloud/pr-5363/docs/8.7/components/console/manage-clusters/cluster-connectors/ Note: Just need to know if this needs to be backported for any other versions - currently only on 8.7 and 8.8. |
docs/components/console/manage-clusters/img/cluster-connector-management-page.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but happy to approve. Great stuff!
I added @sbuettner as a reviewer just so that he's aware of the content |
Thanks @johnBgood I've committed the changes following your review, if you're happy please can I get another approval?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Yes
I'd say we can publish at the end of next week, close to the release |
The preview environment relating to the commit 411c45a has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-5363/index.html |
@johnBgood As per the comments in https://github.com/camunda/product-hub/issues/2750, should we remove this from the 8.7 docs, as it looks like it is only meant for 8.8-alpha3? |
@mesellings nope, the epic you mentioned is just about adding the multiple runtime support, which is not present currently. But we will still release Manage and Run without this feature (in 8.7 + latest alpha) |
Great thanks @johnBgood 👍 |
Description
Add docs for #5362.
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.