Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Identity UI differences for 8.6 and 8.7 #5369

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Conversation

akeller
Copy link
Member

@akeller akeller commented Mar 25, 2025

Description

Follow up to #5331.

  • Updates UI descriptions, including sentence case buttons/tabs
  • Removes (outdated) screenshots on these pages

Reviewers, please ensure I have button and tab names correct and correctly cased.

Important topics that should be revisited outside the scope of this PR:

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@akeller akeller added component:identity Issues related with Identity project deploy Stand up a temporary docs site with this PR available & undocumented This is already available but undocumented and should be released within a week. labels Mar 25, 2025
@akeller akeller self-assigned this Mar 25, 2025
Copy link
Contributor

github-actions bot commented Mar 25, 2025

👋 🤖 🤔 Hello, @conceptualshark! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.7/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.7/self-managed/identity/user-guide/groups/manage-groups.md
  • versioned_docs/version-8.7/self-managed/identity/user-guide/groups/manage-users-roles-to-group.md
  • versioned_docs/version-8.7/self-managed/identity/user-guide/roles/manage-permissions.md
  • versioned_docs/version-8.7/self-managed/identity/user-guide/roles/manage-roles.md
These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
  • versioned_docs/version-8.6/self-managed/identity/user-guide/groups/manage-groups.md
  • versioned_docs/version-8.6/self-managed/identity/user-guide/groups/manage-users-roles-to-group.md
  • versioned_docs/version-8.6/self-managed/identity/user-guide/roles/manage-permissions.md
  • versioned_docs/version-8.6/self-managed/identity/user-guide/roles/manage-roles.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@github-actions github-actions bot temporarily deployed to camunda-docs March 25, 2025 20:38 Destroyed
@github-actions github-actions bot temporarily deployed to camunda-docs March 25, 2025 21:25 Destroyed
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker behaved long enough that I was able to verify the tab/button names. I updated a few areas that didn't make sense without the image, and added a h2 to the permissions so explaining what a "definition" was could just link there.

This seems to be accurate to me, though! Goodbye images!

@github-actions github-actions bot temporarily deployed to camunda-docs March 26, 2025 17:18 Destroyed
Copy link

@FarkasRabai FarkasRabai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@akeller akeller merged commit dd6ef61 into main Mar 28, 2025
8 checks passed
@akeller akeller deleted the identity-rework-86-87 branch March 28, 2025 12:10
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available & undocumented This is already available but undocumented and should be released within a week. component:identity Issues related with Identity project deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants