Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to numpy 2.2 typing notation: use tuple[str, ..] dimension everywhere #60

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Fix to numpy 2.2 typing notation: use tuple[str, ..] dimension everywhere #60

merged 1 commit into from
Feb 22, 2025

Conversation

futurewasfree
Copy link
Contributor

Fix to #59

@futurewasfree futurewasfree force-pushed the trunk branch 2 times, most recently from 20dcd0a to dbeaf43 Compare February 21, 2025 15:02
caniko
caniko reviewed Feb 22, 2025
View reviewed changes
fix(typing): fix to numpy 2.2 typing notation: use tuple[str, ..] dim…
faf070c 
…ension everywhere

chore(version): bump revision
@caniko caniko merged commit 1db5811 into caniko:trunk Feb 22, 2025
21 checks passed
@caniko
Copy link
Owner

caniko commented Feb 22, 2025

Thanks! This looks good 💯

@futurewasfree
Copy link
Contributor Author

Thanks for quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caniko caniko caniko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futurewasfree @caniko