Tests to ensure local user login with authd/broker disabled#1381
Tests to ensure local user login with authd/broker disabled#1381denisonbarbosa wants to merge 1 commit intomainfrom
Conversation
We had these tests before, but we only used to check if the local user still had access to sudo. Now that we disable authd and the brokers through SSH commands, we can reorder the commands a bit to also make sure the local user can authenticate through GDM also.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 99 99
Lines 6690 6690
Branches 111 111
=======================================
Hits 5777 5777
Misses 857 857
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Check that local user can still log in | ||
| Log In | ||
|
|
There was a problem hiding this comment.
Mmh, both "Authd Disabled" and "Broker Disabled" failed in some of the test runs when trying to close the terminal:
- https://authd-e2e-test-logs.adrian-dombeck.workers.dev/pr-1381/run-23896319031-1/devel-authd-google/log.html
- https://authd-e2e-test-logs.adrian-dombeck.workers.dev/pr-1381/run-23896319031-1/devel-authd-msentraid/log.html
I don't recall seeing this failure mode before but I also don't see how it could be caused by this change. Can you make sense of it? If not, let's investigate the failure once we fixed the issue with the logs (https://warthogs.atlassian.net/browse/UDENG-9499).
There was a problem hiding this comment.
I noticed the failures too, but it didn't look related to changes... Maybe it's due to machinectl? But then why the other tests are working? Could be a combination between machinectl and ptyxis
There was a problem hiding this comment.
let's investigate once we have the complete logs
We had these tests before, but we only used them to check if the local user still had access to sudo. Now that we disable authd and the brokers through SSH commands, we can reorder the commands a bit to also make sure the local user can authenticate through GDM.
UDENG-9557