Skip to content

Tests to ensure local user login with authd/broker disabled#1381

Open
denisonbarbosa wants to merge 1 commit intomainfrom
e2e-add-udeng-9557
Open

Tests to ensure local user login with authd/broker disabled#1381
denisonbarbosa wants to merge 1 commit intomainfrom
e2e-add-udeng-9557

Conversation

@denisonbarbosa
Copy link
Copy Markdown
Member

We had these tests before, but we only used them to check if the local user still had access to sudo. Now that we disable authd and the brokers through SSH commands, we can reorder the commands a bit to also make sure the local user can authenticate through GDM.

UDENG-9557

We had these tests before, but we only used to check if the local user
still had access to sudo. Now that we disable authd and the brokers
through SSH commands, we can reorder the commands a bit to also make
sure the local user can authenticate through GDM also.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.35%. Comparing base (33b5a8f) to head (4f51710).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files          99       99           
  Lines        6690     6690           
  Branches      111      111           
=======================================
  Hits         5777     5777           
  Misses        857      857           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@denisonbarbosa denisonbarbosa marked this pull request as ready for review April 2, 2026 11:01
@denisonbarbosa denisonbarbosa requested a review from adombeck April 2, 2026 11:01
Comment on lines +25 to +27
# Check that local user can still log in
Log In

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh, both "Authd Disabled" and "Broker Disabled" failed in some of the test runs when trying to close the terminal:

I don't recall seeing this failure mode before but I also don't see how it could be caused by this change. Can you make sense of it? If not, let's investigate the failure once we fixed the issue with the logs (https://warthogs.atlassian.net/browse/UDENG-9499).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the failures too, but it didn't look related to changes... Maybe it's due to machinectl? But then why the other tests are working? Could be a combination between machinectl and ptyxis

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's investigate once we have the complete logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants