e2e-tests: Allow login to VM as root with empty password in CI#1384
Open
e2e-tests: Allow login to VM as root with empty password in CI#1384
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
+ Coverage 86.32% 86.38% +0.05%
==========================================
Files 99 99
Lines 6690 6690
Branches 111 111
==========================================
+ Hits 5775 5779 +4
+ Misses 859 855 -4
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adombeck
force-pushed
the
UDENG-9610-no-ssh-secrets
branch
from
3ecbaca to
1262c38
Compare
Preparation for allowing login as root without password in CI.
ssh.sh now logs in as root, so we don't need sudo anymore.
These commands are executed as root so we don't need to use sudo.
Automatic changes made by my IDE.
Avoids the need to provide an SSH secret key via GitHub secrets, which are not available in dependabot PRs and PRs by external users. When provisioning the e2e-runner VM locally, we still require an SSH public key.
adombeck
force-pushed
the
UDENG-9610-no-ssh-secrets
branch
from
1262c38 to
ac789a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the need to provide an SSH secret key via GitHub secrets, which are not available in dependabot PRs and PRs by external users.
When provisioning the e2e-runner VM locally, we still require an SSH public key.
UDENG-9610