Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
+ Coverage 87.05% 87.11% +0.05%
==========================================
Files 93 93
Lines 6367 6356 -11
Branches 111 111
==========================================
- Hits 5543 5537 -6
+ Misses 768 764 -4
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like the e2e-tests indeed need to be adapted to the changes on this branch |
I'll close the older PR in favor of this one, will check and update the relevant e2e tests in this branch |
24c0845 to
97991c9
Compare
97991c9 to
daf4285
Compare
daf4285 to
968620c
Compare
968620c to
f679b56
Compare
|
The URL/code matching should now be working fine, but I had to make the regex backwards compatible for the migration tests. please take another look and tell me what u think |
|
|
||
| var firstQrCodeLine string | ||
| // Add some extra vertical space to improve readability | ||
| qrcodeView = append(qrcodeView, " ") |
There was a problem hiding this comment.
Can you please ensure that this does not break how this look in polkit dialogs?
I know we do disable code Auth for now there, but it can still be potentially be visible (especially when the password is will be disabled at completely)
Closes #1263
UDENG-9622
forked branch PR: #1266
This was created to run e2e tests