Skip to content

Improve login layout#1437

Open
nooreldeenmansour wants to merge 4 commits intomainfrom
improve-login-layout
Open

Improve login layout#1437
nooreldeenmansour wants to merge 4 commits intomainfrom
improve-login-layout

Conversation

@nooreldeenmansour
Copy link
Copy Markdown
Member

Closes #1263

UDENG-9622

forked branch PR: #1266

This was created to run e2e tests

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.11%. Comparing base (15c4664) to head (f679b56).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   87.05%   87.11%   +0.05%     
==========================================
  Files          93       93              
  Lines        6367     6356      -11     
  Branches      111      111              
==========================================
- Hits         5543     5537       -6     
+ Misses        768      764       -4     
+ Partials       56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adombeck
Copy link
Copy Markdown
Contributor

Looks like the e2e-tests indeed need to be adapted to the changes on this branch

@nooreldeenmansour
Copy link
Copy Markdown
Member Author

Looks like the e2e-tests indeed need to be adapted to the changes on this branch

I'll close the older PR in favor of this one, will check and update the relevant e2e tests in this branch

@nooreldeenmansour nooreldeenmansour marked this pull request as ready for review April 14, 2026 18:54
@nooreldeenmansour
Copy link
Copy Markdown
Member Author

The URL/code matching should now be working fine, but I had to make the regex backwards compatible for the migration tests. please take another look and tell me what u think


var firstQrCodeLine string
// Add some extra vertical space to improve readability
qrcodeView = append(qrcodeView, " ")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please ensure that this does not break how this look in polkit dialogs?

I know we do disable code Auth for now there, but it can still be potentially be visible (especially when the password is will be disabled at completely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve layout of CLI login prompt without QR code

3 participants