Skip to content

Ignore unknown capabilities and always assume markdown#129

Merged
jpm-canonical merged 8 commits into
mainfrom
IENG-2466-model-capabilities
Jul 13, 2026
Merged

Ignore unknown capabilities and always assume markdown#129
jpm-canonical merged 8 commits into
mainfrom
IENG-2466-model-capabilities

Conversation

@mrmara

@mrmara mrmara commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

webui ignores unknown capabilities. They are shown but do not have any effect on the UI.

Supported capabilities are now:

  • text
  • vision
  • thinking

Moreover notation text:markdown has been dropped and now all text is assumed to be markdown

@farshidtz farshidtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webui now ignores unknown capabilities and silently do not show them in configs.

Web UI is expected to display all capabilities (text, vision, thinking, tools, etc) and react to known ones accordingly. It should not error out on an unknown capability. For example, when vision is there, it should show an attach button. For thinking, it should show a toggle. audio should just be displayed.

@farshidtz farshidtz requested a review from jpm-canonical July 10, 2026 21:27

@jpm-canonical jpm-canonical left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, but I think we can do a larger cleanup here. We always assume Markdown. We do not need to specifically document it, nor keep the isMarkdown computed property. What happens if we remove the isMarkdown property, and all code that refers to it, and just keep the markdown code branches?

@jpm-canonical jpm-canonical left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please drop changes to package-lock.json

Comment thread package-lock.json
@farshidtz farshidtz dismissed their stale review July 13, 2026 12:02

Addressed

@jpm-canonical jpm-canonical merged commit 95b7565 into main Jul 13, 2026
2 checks passed
@jpm-canonical jpm-canonical deleted the IENG-2466-model-capabilities branch July 13, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants