feat: Display connection and polling of models error

src/store/app/thunks.test.ts

@@ -12,7 +12,7 @@ import {
   jujuStateFactory,
 } from "testing/factories/juju/juju";
 
-import { logOut, connectAndStartPolling, connectAndListModels } from "./thunks";
+import { logOut, connectAndStartPolling } from "./thunks";
 
 describe("thunks", () => {
   it("logOut", async () => {
@@ -40,19 +40,6 @@ describe("thunks", () => {
   });
 
   it("connectAndStartPolling", async () => {
-    const action = connectAndStartPolling();
-    const dispatch = jest.fn();
-    const getState = jest.fn(() => rootStateFactory.build());
-    await action(dispatch, getState, null);
-    const dispatchedThunk = await dispatch.mock.calls[1][0](
-      dispatch,
-      getState,
-      null,
-    );
-    expect(dispatchedThunk.type).toBe("app/connectAndListModels/fulfilled");
-  });
-
-  it("connectAndListModels", async () => {
     const dispatch = jest.fn();
     const getState = jest.fn(() =>
       rootStateFactory.build({
@@ -87,7 +74,7 @@ describe("thunks", () => {
         }),
       }),
     );
-    const action = connectAndListModels();
+    const action = connectAndStartPolling();
     await action(dispatch, getState, null);
     expect(dispatch).toHaveBeenCalledWith(
       appActions.connectAndPollControllers({

src/store/app/thunks.ts

@@ -51,21 +51,6 @@ export const connectAndStartPolling = createAsyncThunk<
     state: RootState;
   }
 >("app/connectAndStartPolling", async (_, thunkAPI) => {
-  try {
-    await thunkAPI.dispatch(connectAndListModels());
-  } catch (error) {
-    // XXX Add to Sentry.
-    console.error("Error while trying to connect and list models.", error);
-  }
-});
-
-export const connectAndListModels = createAsyncThunk<
-  void,
-  void,
-  {
-    state: RootState;
-  }
->("app/connectAndListModels", async (_, thunkAPI) => {
   try {
     const storeState = thunkAPI.getState();
     const config = getConfig(storeState);
@@ -93,10 +78,14 @@ export const connectAndListModels = createAsyncThunk<
       }),
     );
   } catch (error) {
-    // XXX Surface error to UI.
     // XXX Send to sentry if it's an error that's not connection related
     // a common error returned by this is:
     // Something went wrong:  cannot send request {"type":"ModelManager","request":"ListModels","version":5,"params":...}: connection state 3 is not open
     console.error("Something went wrong: ", error);
+    thunkAPI.dispatch(
+      generalActions.storeConnectionError(
+        "Error while triggering the connection and polling of models.",
+      ),
+    );
   }
 });

src/store/middleware/check-auth.ts

@@ -86,9 +86,6 @@ export const checkAuthMiddleware: Middleware<
     ];
 
     const thunkAllowlist = [
-      appThunks.connectAndListModels.fulfilled.type,
-      appThunks.connectAndListModels.pending.type,
-      appThunks.connectAndListModels.rejected.type,
       appThunks.connectAndStartPolling.fulfilled.type,
       appThunks.connectAndStartPolling.pending.type,
       appThunks.connectAndStartPolling.rejected.type,