-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-7718 - feat: Remove additional controllers feature #1676
WD-7718 - feat: Remove additional controllers feature #1676
Conversation
Demo starting at https://juju-dashboard-1676.demos.haus |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
- Coverage 94.95% 94.93% -0.03%
==========================================
Files 178 177 -1
Lines 5238 5170 -68
Branches 1515 1500 -15
==========================================
- Hits 4974 4908 -66
+ Misses 244 242 -2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to confirm this feature can be removed before we merge it.
@vladimir-cucu one other thing we should remove in this PR is the docs for adding additional controllers: https://github.com/canonical/juju-dashboard/blob/main/HACKING.md#adding-additional-controllers. |
I converted the PR to draft, so that we do not merge it by mistake until the feature is confirmed.
Done! Thanks for the review. |
Done
QA
/controllers?panel=register-controller
route doesn't open the register controller panel.Details
Screenshots