Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-7718 - feat: Remove additional controllers feature #1676

Merged

Conversation

vladimir-cucu
Copy link
Contributor

Done

  • Removed additional controllers feature.

QA

  • Verify that "Register a controller" button does not appear in controllers page.
  • Verify that /controllers?panel=register-controller route doesn't open the register controller panel.
  • Verify that artifacts related to additional controller feature have been removed.

Details

Screenshots

Screenshot from 2023-12-06 05-52-29

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1676.demos.haus

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (08a85c5) 94.95% compared to head (34c608a) 94.93%.

Files Patch % Lines
src/store/app/thunks.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   94.95%   94.93%   -0.03%     
==========================================
  Files         178      177       -1     
  Lines        5238     5170      -68     
  Branches     1515     1500      -15     
==========================================
- Hits         4974     4908      -66     
+ Misses        244      242       -2     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to confirm this feature can be removed before we merge it.

@huwshimi
Copy link
Contributor

huwshimi commented Dec 6, 2023

@vladimir-cucu one other thing we should remove in this PR is the docs for adding additional controllers: https://github.com/canonical/juju-dashboard/blob/main/HACKING.md#adding-additional-controllers.

@vladimir-cucu vladimir-cucu marked this pull request as draft December 6, 2023 07:28
@vladimir-cucu
Copy link
Contributor Author

Looks good. Just need to confirm this feature can be removed before we merge it.

I converted the PR to draft, so that we do not merge it by mistake until the feature is confirmed.

@vladimir-cucu one other thing we should remove in this PR is the docs for adding additional controllers: https://github.com/canonical/juju-dashboard/blob/main/HACKING.md#adding-additional-controllers.

Done! Thanks for the review.

@huwshimi huwshimi marked this pull request as ready for review January 15, 2024 08:56
@vladimir-cucu vladimir-cucu merged commit 5e8ef26 into canonical:main Jan 15, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants