WD-8294 - feat: Display connection and polling of models error #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://juju-dashboard-1682.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
=========================================
+ Coverage 0 94.97% +94.97%
=========================================
Files 0 178 +178
Lines 0 5177 +5177
Branches 0 1505 +1505
=========================================
+ Hits 0 4917 +4917
- Misses 0 240 +240
- Partials 0 20 +20 ☔ View full report in Codecov by Sentry. |
huwshimi
approved these changes
Jan 24, 2024
huwshimi
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
connectAndStartPolling()fails, the error is sent to Redux store, and caught and displayed inConnectionErrorcomponent.QA
tryblock inconnectAndStartPolling()by throwing a dummy error there e.g.throw new Error("Dummy error.");.ConnectionErrorcomponent renders, same as in the attached screenshot.Error while triggering the connection and polling of models. Error: Dummy error.followed by the stack trace.Details
Screenshots