WD-8394 - Add secrets tab #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://juju-dashboard-1684.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1684 +/- ##
=========================================
+ Coverage 0 94.93% +94.93%
=========================================
Files 0 178 +178
Lines 0 5175 +5175
Branches 0 1502 +1502
=========================================
+ Hits 0 4913 +4913
- Misses 0 242 +242
- Partials 0 20 +20 ☔ View full report in Codecov by Sentry. |
vladimir-cucu
approved these changes
Jan 22, 2024
| @@ -242,6 +243,7 @@ const Model = () => { | |||
| </> | |||
| )} | |||
| {shouldShow("logs", query.activeView) && <Logs />} | |||
| {shouldShow("secrets", query.activeView) && <Secrets />} | |||
There was a problem hiding this comment.
I think we might need to add case "secrets": in the definition of shouldShow. Currently, the Secrets page doesn't render.
| { | ||
| active: activeView === "secrets", | ||
| label: "Secrets", | ||
| onClick: (e: MouseEvent) => handleNavClick(e), |
There was a problem hiding this comment.
Should we add a test here?
vladimir-cucu
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-8394