-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-8309 - feat: Display error when trying to retrieve models info #1686
WD-8309 - feat: Display error when trying to retrieve models info #1686
Conversation
Demo starting at https://juju-dashboard-1686.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
=========================================
+ Coverage 0 95.02% +95.02%
=========================================
Files 0 178 +178
Lines 0 5207 +5207
Branches 0 1524 +1524
=========================================
+ Hits 0 4948 +4948
- Misses 0 239 +239
- Partials 0 20 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, one test to add (feel free to merge this once you add that test).
Done
fetchAllModelStatuses()
.fetchAllModelStatuses()
. Else, throw the error back, so that it is further caught inmodelPollerMiddleware()
.modelPollerMiddleware()
, send "Unable to load models." error if it is the first polling and all models error out, "Unable to load some models." error if it is the first polling and some models error out, "Unable to load latest model data." if it is later polling and the error appears infetchAllModelStatuses()
call, else send "Unable to list or update models." error. The error should be sent tojuju -> modelsErrors
in Redux store.pages/ModelsIndex/ModelsIndex.tsx
.QA
modelPollerMiddleware()
to throw an error on line 217.Models
page and logged into the console.Details
Screenshots