Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8431 - Fetch and store secrets #1687

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

huwshimi
Copy link
Contributor

Done

  • Fetch and store secrets.

QA

  • Set up a controller with Juju 3.3.1.
  • Add some secrets to a model with: juju add-secret my-apitoken token=34ae35facd4
  • Open the dashboard and navigate to the model.
  • Click on the Secrets tab.
  • The secrets should get fetch and displayed in a list.

Details

https://warthogs.atlassian.net/browse/WD-8431

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1687.demos.haus

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e320315) 94.93% compared to head (ea6bb02) 95.05%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
+ Coverage   94.93%   95.05%   +0.11%     
==========================================
  Files         178      179       +1     
  Lines        5175     5274      +99     
  Branches     1502     1518      +16     
==========================================
+ Hits         4913     5013     +100     
+ Misses        242      241       -1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested it yesterday as described in the QA section and works as expected with local juju v3.3.1.

@huwshimi huwshimi merged commit 0d0ae5f into canonical:main Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants