-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-8395 - Add secrets table #1689
Conversation
Demo starting at https://juju-dashboard-1689.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1689 +/- ##
==========================================
+ Coverage 95.13% 95.15% +0.01%
==========================================
Files 179 181 +2
Lines 5306 5320 +14
Branches 1540 1545 +5
==========================================
+ Hits 5048 5062 +14
Misses 238 238
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works as expected locally! 🚀 Added a small open-ended questions.
} | ||
return secrets.map((secret) => ({ | ||
name: secret.label, | ||
id: secret.uri.replace(/^secret:/, ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering if maybe it might make it more user-friendly if we use a Tooltip
here in order to show the full id? Maybe we could also do something similar with "owner" as well, considering that it takes a lot of vertical space in the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-8395
Screenshots