Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8395 - Add secrets table #1689

Merged
merged 2 commits into from
Jan 29, 2024
Merged

WD-8395 - Add secrets table #1689

merged 2 commits into from
Jan 29, 2024

Conversation

huwshimi
Copy link
Contributor

Done

  • Add a table of secrets.
  • Add a reusable component for displaying relative dates.

QA

  • Go to the secrets tab for a model with secrets.
  • You should see a basic table displaying the secrets (there are quite a few changes to come in future PRs).

Details

https://warthogs.atlassian.net/browse/WD-8395

Screenshots

Screenshot 2024-01-29 at 12 16 37 pm

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1689.demos.haus

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d0ae5f) 95.13% compared to head (8dac3b1) 95.15%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
+ Coverage   95.13%   95.15%   +0.01%     
==========================================
  Files         179      181       +2     
  Lines        5306     5320      +14     
  Branches     1540     1545       +5     
==========================================
+ Hits         5048     5062      +14     
  Misses        238      238              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works as expected locally! 🚀 Added a small open-ended questions.

}
return secrets.map((secret) => ({
name: secret.label,
id: secret.uri.replace(/^secret:/, ""),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if maybe it might make it more user-friendly if we use a Tooltip here in order to show the full id? Maybe we could also do something similar with "owner" as well, considering that it takes a lot of vertical space in the table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good suggestions. The ID field is going to have a copy button to get the full URI (WD-8396) and I thought I'd leave other responsive improvements until after all the data is in the table so that I can see what needs adjusting (WD-8521).

@huwshimi huwshimi merged commit 91b9686 into canonical:main Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants