WD-8546 - Create secrets #1693
WD-8546 - Create secrets #1693
Conversation
|
Demo starting at https://juju-dashboard-1693.demos.haus |
huwshimi
changed the title
huwshimi
force-pushed
the
secrets-create
branch
from
f128962 to
793a373
Compare
| @@ -78,7 +78,8 @@ | |||
| "react-scripts": "5.0.1", | |||
| "react-useportal": "1.0.19", | |||
| "redux": "5.0.1", | |||
| "vanilla-framework": "4.5.1" | |||
| "vanilla-framework": "4.5.1", | |||
| "yup": "1.3.3" | |||
There was a problem hiding this comment.
This is the validation library that gets used in our other projects that use Formik (I was surprised to see it wasn't being used already).
|
|
||
| import FormikField from "./FormikField"; | ||
|
|
||
| describe("FormikField", () => { |
There was a problem hiding this comment.
These tests were copied from MAAS.
| value?: HTMLProps<HTMLElement>["value"]; | ||
| } & ComponentProps<C>; | ||
|
|
||
| const FormikField = <C extends ElementType | ComponentType = typeof Input>({ |
There was a problem hiding this comment.
This component was copied from MAAS.
| error?: string | null, | ||
| ) => void; | ||
|
|
||
| export const useModelConnectionCallback = (modelUUID?: string) => { |
There was a problem hiding this comment.
I've split up this hook so that you can get a function to connect to a model and call a callback.
| ); | ||
| }; | ||
|
|
||
| export const useModelConnection = ( |
There was a problem hiding this comment.
This version also calls function to connect to the model.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 95.14% 95.29% +0.15%
==========================================
Files 183 184 +1
Lines 5400 5468 +68
Branches 1577 1592 +15
==========================================
+ Hits 5138 5211 +73
+ Misses 242 238 -4
+ Partials 20 19 -1 ☔ View full report in Codecov by Sentry. |
vladimir-cucu
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-8546