Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8412 - Hide secrets tab #1696

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Feb 2, 2024

Done

  • Hide the secrets tab if the model doesn't support it.

QA

  • Connect to a Juju 3.3 controller.
  • Go to a model details page.
  • You should see a secrets tab.
  • Connect to a Juju 2.9 controller.
  • Go to a model details page.
  • You should not see a secrets tab.

Details

https://warthogs.atlassian.net/browse/WD-8412

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1696.demos.haus

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa059d2) 95.04% compared to head (85102ce) 95.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
+ Coverage   95.04%   95.06%   +0.02%     
==========================================
  Files         182      182              
  Lines        5325     5354      +29     
  Branches     1545     1550       +5     
==========================================
+ Hits         5061     5090      +29     
  Misses        243      243              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected locally! 🚀

@huwshimi huwshimi merged commit d949de8 into canonical:main Feb 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants