Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8617 - fix: Fix displaying the first colorless part of the message in WebCLI #1697

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

vladimir-cucu
Copy link
Contributor

@vladimir-cucu vladimir-cucu commented Feb 2, 2024

Done

  • Issue resolved: Until now, if the content in the WebCLI started straight away with a color, we displayed twice the beginning of the content. The second time it was displayed without color and with the color encoding appended to it (see screenshots).

Details

Screenshots

Before:
Screenshot from 2024-02-02 12-48-11
After:
Screenshot from 2024-02-02 12-48-33

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1697.demos.haus

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0559f36) 95.07% compared to head (8775719) 95.13%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   95.07%   95.13%   +0.06%     
==========================================
  Files         183      183              
  Lines        5359     5369      +10     
  Branches     1555     1568      +13     
==========================================
+ Hits         5095     5108      +13     
+ Misses        243      241       -2     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now.

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much cleaner now.

@vladimir-cucu vladimir-cucu merged commit a421c38 into canonical:main Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants