-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WD-8617 - fix: Fix displaying the first colorless part of the message in WebCLI #1697
WD-8617 - fix: Fix displaying the first colorless part of the message in WebCLI #1697
Conversation
Demo starting at https://juju-dashboard-1697.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
+ Coverage 95.07% 95.13% +0.06%
==========================================
Files 183 183
Lines 5359 5369 +10
Branches 1555 1568 +13
==========================================
+ Hits 5095 5108 +13
+ Misses 243 241 -2
+ Partials 21 20 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is much cleaner now.
Done
WebCLI
started straight away with a color, we displayed twice the beginning of the content. The second time it was displayed without color and with the color encoding appended to it (see screenshots).Details
Screenshots
Before:


After: