Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-8566 - fetch new secrets #1700

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Feb 6, 2024

Done

  • Fetch the list of secrets after creating a new one.

QA

  • Go to the secrets list.
  • Open the add secret panel. Fill out the form and submit.
  • The panel should close and the list of secrets should reload with the new secret.

Details

https://warthogs.atlassian.net/browse/WD-8566

@webteam-app
Copy link

Demo starting at https://juju-dashboard-1700.demos.haus

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2cf0417) 95.28% compared to head (3126f4d) 95.27%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   95.28%   95.27%   -0.02%     
==========================================
  Files         185      185              
  Lines        5474     5478       +4     
  Branches     1591     1591              
==========================================
+ Hits         5216     5219       +3     
- Misses        239      240       +1     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +79 to +81
const modelConnectionCallback = useModelConnectionCallback(modelUUID);
return useCallback(() => {
modelConnectionCallback(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook has been changed to return a callback to fetch the secrets. The rest of the changes are just indentation changes.

Copy link
Contributor

@vladimir-cucu vladimir-cucu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected locally! 👍

@huwshimi huwshimi merged commit 08337fd into canonical:main Feb 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants