-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): Use loglevel library for error handling #1845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you want to do this in the same PR, but we should probably do the same for our console.log
calls as well.
We might want to default to silent in prod and maybe in tests as well.
For prod we could have a console.log when the app loads to output something like 'Run log.setLevel("trace") to output errors to the console.'
and then expose loglevel as a global log
variable.
aca9cda
to
46b2aca
Compare
While I'm working on setting the log levels, I'm not sure I've initialised it right in test setup file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions here so that you can remove the remaining logging mocks.
src/panels/CharmsAndActionsPanel/CharmsAndActionsPanel.test.tsx
Outdated
Show resolved
Hide resolved
It seems like it's working for me, there are no errors being displayed in the console and if I add |
46b2aca
to
7f05548
Compare
Okay, I've not made further changes to this since it was reported to be working fine. Additionally, I have replaced |
2a2fb7f
to
7b769dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this.
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-18724