Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WD-19117 - refactor: create hook for handling fetching permission #1849

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Feb 7, 2025

Done

  • Create a hook that handles fetching permissions if they haven't already been fetched, and returning the result.

QA

  • Connect to JIMM.
  • Check that that the permissions and logs items appear in the side nav.

Details

https://warthogs.atlassian.net/browse/WD-19117

@webteam-app
Copy link

Copy link

github-actions bot commented Feb 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 98.02% (🎯 95%) 14660 / 14955
🟢 Statements 98.02% (🎯 95%) 14660 / 14955
🟢 Functions 98.19% (🎯 95%) 598 / 609
🟢 Branches 92.14% (🎯 90%) 2966 / 3219
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/PrimaryNav/PrimaryNav.tsx 100% 93.1% 100% 100%
src/juju/api-hooks/permissions.ts 100% 100% 100% 100%
src/store/juju/selectors.ts 97.41% 92.6% 100% 97.41% 551, 575, 587, 599, 627-628, 699, 723, 730, 736, 812-813, 836-837, 873-874, 899-900, 928-929
Generated in workflow #41 for commit 7758682 by the Vitest Coverage Report Action

Copy link
Contributor

@Ninfa-Jeon Ninfa-Jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ninfa-Jeon Ninfa-Jeon merged commit 44d98b1 into canonical:main Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants