Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: access buttons link to groups when using rebac #1853

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: access buttons link to groups when using rebac #1853

merged 1 commit into from
Feb 25, 2025

Conversation

huwshimi
Copy link
Contributor

Done

  • Make a shared access button to handle logic in one place (the existing access button wraps the new component as it sets the appearance for all the model tables).
  • Update the access button to link to groups when using JIMM.

QA

  • Connect to a local Juju controller.
  • In the model list hover a model and click on the access button and it should show the access panel.
  • Connect to JIMM.
  • In the model list hover a model and click on the access button and it should take you to the groups page.

Details

https://warthogs.atlassian.net/browse/WD-19058
https://warthogs.atlassian.net/browse/WD-19057

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 97.87% (🎯 95%) 14295 / 14606
🟢 Statements 97.87% (🎯 95%) 14295 / 14606
🟢 Functions 98.19% (🎯 95%) 597 / 608
🟢 Branches 92.04% (🎯 90%) 2962 / 3218
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/urls.ts 100% 100% 100% 100%
src/components/AccessButton/AccessButton.tsx 100% 100% 100% 100%
src/components/ModelTableList/AccessButton/AccessButton.tsx 100% 100% 100% 100%
src/components/ModelTableList/CloudGroup/CloudGroup.tsx 97.58% 66.66% 100% 97.58% 53, 72, 126
src/components/ModelTableList/OwnerGroup/OwnerGroup.tsx 98.31% 75% 100% 98.31% 68, 117
src/components/ModelTableList/StatusGroup/StatusGroup.tsx 100% 100% 100% 100%
src/components/PrimaryNav/PrimaryNav.tsx 100% 93.1% 100% 100%
src/pages/EntityDetails/Model/Model.tsx 98.91% 94.87% 100% 98.91% 63-64
src/pages/Permissions/Permissions.tsx 100% 100% 100% 100%
Generated in workflow #125 for commit 9a9d621 by the Vitest Coverage Report Action

@huwshimi huwshimi force-pushed the rebac-manage-access-buttons branch from b5c8616 to 614752f Compare February 13, 2025 06:49
@huwshimi huwshimi marked this pull request as ready for review February 18, 2025 02:02
@huwshimi huwshimi force-pushed the rebac-manage-access-buttons branch from 614752f to b7a1a07 Compare February 19, 2025 05:03
@huwshimi huwshimi force-pushed the rebac-manage-access-buttons branch from b7a1a07 to 9a9d621 Compare February 21, 2025 06:13
Ninfa-Jeon
Ninfa-Jeon approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@Ninfa-Jeon Ninfa-Jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ninfa-Jeon
Copy link
Contributor

Ninfa-Jeon commented Feb 23, 2025 •
edited
Loading

Unable to QA due to 502 error in JIMM. Will retry on Monday Done

@Ninfa-Jeon Ninfa-Jeon merged commit cff040a into canonical:main Feb 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ninfa-Jeon Ninfa-Jeon Ninfa-Jeon approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huwshimi @webteam-app @Ninfa-Jeon