Fix rendering of local charm name and icon #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting demo at: https://jaas-dashboard-canonical-web-and-design-pr-528.run.demo.haus/ |
anthonydillon
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
|
@anthonydillon I can't see the demo, does it now use the icon from here? - #527 |
|
Added +1 assuming the icon here will be added soon. |
added 5 commits
May 29, 2020 15:28
…charm icon border.
hatched
force-pushed
the
local-charm-support
branch
from
b668aa2 to
1dde375
Compare
|
@spencerbygraves I've updated it to render the default icon and added a screenshot to show you what it looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
When a model contained a local charm it would break the rendering because it was receiving the name in an incorrect format. This renders a default charm icon when it's a local charm for the time being and fixes a styling issue with the closed sidebar.
QA
https://github.com/dshcherb/cockroachdb-operatorjuju deploy .juju dashboardand view the built in dashboard to accept the self-signed cert.baseControllerURLto the ip address and port (if any) from above.isJujutotrueidentityProviderAvailabletofalse./runDetails
Fixes #515
Fixes #527
Fixes #534
Screenshots